Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: graphics blend mode not being set correctly for large Graphics #10480

Merged
merged 2 commits into from Apr 30, 2024

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented Apr 26, 2024

When a graphics is a certain size, we no longer batch it. There was a bug where the blend mode was not being set when rendering these larger graphics. All fixed now!

Test included!

fixes #10471

Copy link

codesandbox-ci bot commented Apr 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d6249f:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title fix for bug where graphics blend mode was not being set correctly for large Graphics Fix: graphics blend mode not being set correctly for large Graphics Apr 30, 2024
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 30, 2024
@Zyie Zyie added this pull request to the merge queue Apr 30, 2024
Merged via the queue into dev with commit f06dd68 Apr 30, 2024
4 checks passed
@Zyie Zyie deleted the bugfix/graphics-blend branch April 30, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: use round cap,blendmode not work
3 participants