Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use texSubImage2D if not necessary to improve performance #10383

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Do not use texSubImage2D if not necessary to improve performance #10383

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52a2980
Do not use texSubImage2D if not necessary to improve performance
gfodor Mar 27, 2024
754f735
Merge branch 'dev' into avoid-texSubImage2D
GoodBoyDigital Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/rendering/renderers/gl/texture/uploaders/glUploadImageResource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,10 @@ export const glUploadImageResource = {
}
else if (glWidth === textureWidth || glHeight === textureHeight)
{
gl.texSubImage2D(
gl.TEXTURE_2D,
0,
0,
gl.texImage2D(
glTexture.target,
0,
glTexture.internalFormat,
glTexture.format,
glTexture.type,
source.resource as TexImageSource
Expand Down