Feat: Add Texture.sourceFrom
#10318
Open
Feat: Add Texture.sourceFrom
#10318
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2adc4b7:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! so we no longer have a function that directly functions as
BaseTexture.fromI see three possible solutions as to where this one liner could go:
1:
TextureSource.from- most closely resembles v7. But technically it would most likely return something that extends TextureSource, is this ok? We would be swapping convenance for purity!2:
getTextureSourceFrom- create a floating function that can be imported that does the trick. might be a bit tricky to use for devs as they would need to know about its existence. But would be pure!3:
Textue.sourceFrom- same as option one, but on the texture class. (currently implemented)I could probably be sold on either option one or three! But would be good to get other peoples opinions!