address feedback

pixijs · May 13, 2024 · 2f10ef4 · 2f10ef4
1 parent 6a1f23f
commit 2f10ef4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/src/scene/container/container-mixins/effectsMixin.ts b/src/scene/container/container-mixins/effectsMixin.ts
@@ -61,11 +61,6 @@ export const effectsMixin: Partial<Container> = {
             renderGroup.structureDidChange = true;
         }
 
-        // if (this.renderGroup)
-        // {
-        //     this.renderGroup.structureDidChange = true;
-        // }
-
         this._updateIsSimple();
     },
     /**

diff --git a/tests/scene/scene.tests.ts b/tests/scene/scene.tests.ts
@@ -274,7 +274,6 @@ describe('Scene', () =>
 
         expect(container.renderGroup).toEqual(container.renderGroup);
         expect(container2.parentRenderGroup).toEqual(container.renderGroup);
-        // expect(child.renderGroup).toEqual(container2.renderGroup);
 
         expect(child2.parentRenderGroup).toEqual(container2.renderGroup);
         expect(child3.parentRenderGroup).toEqual(container.renderGroup);
@@ -365,6 +364,7 @@ describe('Scene', () =>
         expect(child3.relativeRenderGroupDepth).toEqual(1);
     });
 
+    // eslint-disable-next-line jest/expect-expect
     it('should register update in the update array..', async () =>
     {
         const container = new Container({
@@ -425,8 +425,6 @@ describe('Scene', () =>
         compareUpdateList([child, container2], container.renderGroup, 1);
 
         compareUpdateList([child2, child3], container.renderGroup, 2);
-
-        expect(true).toBeTrue();
     });
 
     it('should appear in update array correctly if it changes layer group', async () =>
@@ -470,10 +468,9 @@ describe('Scene', () =>
         compareUpdateList([], container.renderGroup, 1);
 
         compareUpdateList([child], container2.renderGroup, 2);
-
-        expect(true).toBeTrue();
     });
 
+    // eslint-disable-next-line jest/expect-expect
     it('should appear in update array correctly if it changes layer group parents', async () =>
     {
         const container = new Container({
@@ -532,10 +529,9 @@ describe('Scene', () =>
         compareUpdateList([child], container.renderGroup, 1);
 
         compareUpdateList([child3], container2.renderGroup, 1);
-
-        expect(true).toBeTrue();
     });
 
+    // eslint-disable-next-line jest/expect-expect
     it('should update layers correctly if you attach a render group and it has updated children..', async () =>
     {
         const container = new Container();
@@ -582,8 +578,6 @@ describe('Scene', () =>
 
         compareUpdateList([child], container.renderGroup, 1);
 
-        expect(true).toBeTrue();
-
         // console.log(container2.layerGroup.childrenToUpdate[1])
         // expect(container2.layerGroup.childrenToUpdate[1]).toEqual({
         //     list: [child2, child3],