Add "Previous" and "Next" navigation controls to album presenters (WIP) #4881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbliznikova
changed the title
Hi! Thanks for reviewing my code! |
mbliznikova
force-pushed
the
4880_add_navigation_controls_to_album_presenters
branch
from
4f49943
to
a34073a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses the feature request #4880, adds a navigation arrows to the carousel component in PhotoAlbumPresenter.vue and MixedAlbumPresenter.vue.
Also, was thinking, would it be good to have navigation arrows as a user setting? I hesitated, because it seems to me as probably insignificant setting among a lot of another settings, but let's discuss, if you have an another opinion.
Please feel free to suggest a changes/improvements to this feature and just feel free to discuss and ask any questions 馃檪
Edit: increased the target area around navigation arrows, now it's along the whole picture sides accordingly; made navigation arrows appear only when hovering above them.
See the screenshot from my local deployment with navigation arrows for photo album:
