Import deprecated scipy.linalg.triu from numpy.triu instead #3524
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing Import of depecrated triu function imported from scipy lib
piskvorky
reviewed
Apr 3, 2024
|
Done updated the PR |
piskvorky
changed the title
piskvorky
changed the title
piskvorky
changed the title
13 tasks
|
@mpenkov this fix seems important. Another maintenance release of Gensim may be timely anyway – drop unsupported Python versions, add new Python versions, etc. WDYT? How about a release session, one of these days? |
|
Sure, we need to work out what's going on with the Windows builds, first. That's been on my todo list for a while. |
mpenkov
approved these changes
Apr 5, 2024
mpenkov
approved these changes
Apr 5, 2024
Closed
|
The failing Windows builds seem to be caused by pypa/cibuildwheel#1740. |
|
Thank you for pointing that out @unlimitedsola |
ghpzin
added a commit
to ghpzin/nixpkgs
that referenced
this pull request
May 2, 2024
python3Packages.scipy update to 1.13.0 removed triu. Patch from upstream commit replaces it with numpy.triu if import from scipy.linalg.triu fails. piskvorky/gensim#3524 scipy/scipy#19674
ghpzin
added a commit
to ghpzin/nixpkgs
that referenced
this pull request
May 2, 2024
python3Packages.scipy update to 1.13.0 removed triu. Patch from upstream commit replaces it with numpy.triu if import from scipy.linalg.triu fails. piskvorky/gensim#3524 scipy/scipy#19674
ghpzin
added a commit
to ghpzin/nixpkgs
that referenced
this pull request
May 2, 2024
python3Packages.scipy update to 1.13.0 removed triu. Patch from upstream commit replaces it with numpy.triu if import from scipy.linalg.triu fails. piskvorky/gensim#3524 scipy/scipy#19674
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scipy package latest released has removed the triu function due to its support already provided in numpy package
Diff from the scipy library :
scipy/scipy@5721702#diff-6482beada610f60c724811cf77561f2bde8fd44ed2349939e505d28746a6d078
Removing the triu import from scipy library and getting it instead from numpy
Fixes #3525.