Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper usage of update_every in LdaMulticore #3140

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Proper usage of update_every in LdaMulticore #3140

wants to merge 2 commits into from

Conversation

jonaschn
Copy link
Contributor

@jonaschn jonaschn commented May 13, 2021 •
edited

LdaMulticore offers a different API compared to LdaModel.
This is unnecessary complex.
Neither the removed batch nor the update_every parameters are documented for LdaMulticore.
However, LdaMulticore inherits update_every from LdaMulticore anyway.

This PR removes the batch parameter and uses the update_every parameter analog to it's usage in LdaModel:
batch=True becomes update_every=0
batch=False becomes update_every=1
New: update_every >= 2 (as used in ldamodel.py)

TODO:

  • check usage of eval_every (should or should not depend on update_every!?)

@jonaschn
Use update_every in ldamulticore.py
e7764da 
batch=True --> update_every=0
batch=False --> update_every=1
New: update_every >= 2 (as used in ldamodel.py)
@jonaschn
Simplify updatetype
1712e6a
@jonaschn jonaschn mentioned this pull request May 13, 2021
Closed
@mpenkov mpenkov added this to Triage in PR triage 2021-06 Jun 22, 2021
@mpenkov mpenkov moved this from Triage to Draft in PR triage 2021-06 Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PR triage 2021-06
Draft
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonaschn