Fix word2vec doc-comment example of KeyedVectors usage, issue 2669 #2789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpenkov , much appreciated if this could be reviewed. This is my first PR. Please let me know if any changes are required. Thank you. |
|
Note to self: resolve conflict |
|
@bvinesh Yes, let's get rid of the temporary subdirectory and simply use the CWD. Are you able to finish this PR? |
mpenkov
added
the
stale
mpenkov
moved this from Needs work before merge
to Handle after next release
in PR triage 2021-06
|
@bvinesh we're planning a new release of Gensim soon. We could include this PR if you finish it – please let us know (or close it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2669
Proposal is to remove use of get_tmpfile and (optionally) change to a temp directory instead. Let me know if you prefer a different approach and I will change it. Thank you.