New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore glibc specific code #1989
base: master
Are you sure you want to change the base?
Conversation
Makefile
Outdated
@@ -9,7 +9,7 @@ REGRESS = $(EXTENSION) | |||
|
|||
DATA = pipelinedb--1.0.0.sql | |||
EXTRA_CLEAN = src/test/regress/expected/$(REGRESS).out src/test/regress/sql/$(REGRESS).sql | |||
SHLIB_LINK += /usr/lib/libzmq.a -lstdc++ | |||
SHLIB_LINK += -lzmq -lstdc++ -fPIC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found this on #1773 (comment)
no idea what I'm doing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this breaks the wanted static linking of libzmq in the extension, as I had to install zeromq-dev
in the runtime env.
@@ -6,7 +6,9 @@ | |||
* | |||
*------------------------------------------------------------------------- | |||
*/ | |||
#ifdef GLIBC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, not sure if that's even a good idea; found a similar fix in https://github.com/PowerDNS/pdns/pull/1958/files
@@ -126,6 +128,7 @@ ContQueryDatabaseMetadataSize(void) | |||
void | |||
debug_segfault(SIGNAL_ARGS) | |||
{ | |||
#ifdef GLIBC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe there is a way to find the "else" version for musl ?
Signed-off-by: Klein Florian <florian.klein@free.fr>
see #1692 |
see #1578 |
Excellent, many thanks for this solution and the edits, I wish there was an alpine-ready version out of the box. |
Thanks for this work, @docteurklein! |
I got pipelinedb to compile on alpine 馃巿 馃嵏
here is the way I built it:
The server is booting, so i'm going to sleep now :)