Commands for prompt #199
Open
Commands for prompt #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcooper
commented
Feb 1, 2024
| @@ -1539,7 +1540,7 @@ Print message(s) in green do: | |||
| prompt.ok(...) | |||
| ``` | |||
|
|
|||
| #### 2.12.2 warn | |||
| #### 2.11.2 warn | |||
There was a problem hiding this comment.
Minor edit to the readme - this should be done regardless of if this PR goes through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This PR adds in an entirely new type to the prompt - commands.
This fulfills the ability to have an interactive shell where the user is able to input items and the console shows possible commands that they can run given the currently entered characters.
Screen.Recording.2024-02-01.at.1.00.23.PM.mov
Why are we doing this? / Benefits
This acts very similar to a single line input, but it provides hints toward what you should enter. I couldn't find a good way to do this with the current implementation so I decided to add my own. I think this is very useful in command like systems where you have a choice, but that choice also has optional or different post-fix than the selection we are actually using.
In the future I could see adding support for things like optional arguments, or different ways to color/display.
Drawbacks
Adds another system to support, the single-line input basically does this except without the suggestions, it's not a new type of input, just a new type of suggestions. Could possibly be added to single-line input instead.
Requirements
masterbranch?