Reduce syscall/js calls needed to load Uint8Array #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backkem
approved these changes
Jul 15, 2019
Reimplements the uint8ArrayValueToBytes js util used for copying buffers from js into wasm using TypedArray.prototype.set to improve performance.
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
=======================================
Coverage 76.64% 76.64%
=======================================
Files 58 58
Lines 4038 4038
=======================================
Hits 3095 3095
Misses 687 687
Partials 256 256Continue to review full report at Codecov.
|
|
Thank you so much for the contribution @slugalisk! We are excited you are using Pion, if there is anything we can do to help please reach out on here or over Slack! |
|
My pleasure! Thanks for the awesome lib! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the result buffer wrapped in a js.TypedArray js will do the copy for us. See: WebAssembly/design#1231 (comment)