Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rt Notebook example - corrected #1523

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

I-Bouros
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (abcc8e5) to head (3d7ac11).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         9577      9577           
=========================================
  Hits          9577      9577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelClerx
Copy link
Member

Can you give a bit of background about this example? What's the reason for including it (from a PINTS point of view: which features does it highlight)?

In its current form I don't think it belong in the "toy" section of examples, as those all showcase a toy model included in the PINTS module.

If you did want to make this into a PINTS toy problem, we would have to think about how (or whether) to include the CSV data, as we would have to then package this data as part of the pints module

@I-Bouros
Copy link
Contributor Author

Can you give a bit of background about this example? What's the reason for including it (from a PINTS point of view: which features does it highlight)?

In its current form I don't think it belong in the "toy" section of examples, as those all showcase a toy model included in the PINTS module.

If you did want to make this into a PINTS toy problem, we would have to think about how (or whether) to include the CSV data, as we would have to then package this data as part of the pints module

It's meant to be an additional example for the paper, and to showcase how someone can try and define their own logPDF objects rather than resorting to singleOutput problems. I did struggle to find a good place to include it, to be honest.

@MichaelClerx
Copy link
Member

I suppose it could always go under "Miscellaneous", or it could go in a separate repo? (pints-team/rt-estimation-renewal-equation?), or in a repo with things related to the paper?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants