Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPM support #588

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix SPM support #588

wants to merge 4 commits into from

Conversation

woxtu
Copy link

@woxtu woxtu commented Nov 19, 2020

Hi,

The current release installed by SPM can't import headers as follows:

fatal error: 'PINRemoteImage/PINRemoteImage.h' file not found
#import <PINRemoteImage/PINRemoteImage.h>
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

And categories are not loaded:

error: no visible @interface for 'NSImageView' declares the selector 'pin_setImageFromURL:'
[imageView pin_setImageFromURL:[NSURL URLWithString:@"http://pinterest.com/kitten.jpg"]];
 ~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~

This PR contains the following changes to fix that:

  • Put header files back next to source files
  • Create new public headers directory
  • Add missing imports to the framework header

@grangej
Copy link

grangej commented Dec 1, 2020

This does seem to fix the build but it seems to break the categories.

@woxtu
Copy link
Author

woxtu commented Dec 2, 2020

@grangej
Thank you for your pointing out.
I could confirm that categories is not loaded, and maybe the current release has same issue.
Anyway I'll fix that.

@grangej
Copy link

grangej commented Dec 12, 2020

Awesome , any chance we can get this merged ??

@mthole
Copy link

mthole commented Apr 16, 2021

Bump?

@mthole
Copy link

mthole commented Apr 16, 2021

FYI: This may be taken care of by #586 already, which is merged to master but not in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants