Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pingone_mfa_device_policy: Migrate to plugin framework #809

Draft
wants to merge 5 commits into
base: v1.0.0-development
Choose a base branch
from

Conversation

patrickcping
Copy link
Collaborator

@patrickcping patrickcping commented May 10, 2024

Change Description

  • Migrate pingone_mfa_device_policy to plugin framework

Required SDK Upgrades

  • github.com/patrickcping/pingone-go-sdk-v2/mfa v0.19.0

Testing Shell Command

TF_ACC=1 go test -v -timeout 3000s -run ^TestAccMFADevicePolicy_ github.com/pingidentity/terraform-provider-pingone/internal/service/mfa

Testing Results

Expand Results
=== RUN   TestAccMFADevicePolicy_RemovalDrift
=== PAUSE TestAccMFADevicePolicy_RemovalDrift
=== RUN   TestAccMFADevicePolicy_NewEnv
=== PAUSE TestAccMFADevicePolicy_NewEnv
=== RUN   TestAccMFADevicePolicy_SMS_Full
=== PAUSE TestAccMFADevicePolicy_SMS_Full
=== RUN   TestAccMFADevicePolicy_SMS_Minimal
=== PAUSE TestAccMFADevicePolicy_SMS_Minimal
=== RUN   TestAccMFADevicePolicy_SMS_Change
=== PAUSE TestAccMFADevicePolicy_SMS_Change
=== RUN   TestAccMFADevicePolicy_Voice_Full
=== PAUSE TestAccMFADevicePolicy_Voice_Full
=== RUN   TestAccMFADevicePolicy_Voice_Minimal
=== PAUSE TestAccMFADevicePolicy_Voice_Minimal
=== RUN   TestAccMFADevicePolicy_Voice_Change
=== PAUSE TestAccMFADevicePolicy_Voice_Change
=== RUN   TestAccMFADevicePolicy_Email_Full
=== PAUSE TestAccMFADevicePolicy_Email_Full
=== RUN   TestAccMFADevicePolicy_Email_Minimal
=== PAUSE TestAccMFADevicePolicy_Email_Minimal
=== RUN   TestAccMFADevicePolicy_Email_Change
=== PAUSE TestAccMFADevicePolicy_Email_Change
=== RUN   TestAccMFADevicePolicy_Mobile_Full
=== PAUSE TestAccMFADevicePolicy_Mobile_Full
=== RUN   TestAccMFADevicePolicy_Mobile_IntegrityDetectionErrors
=== PAUSE TestAccMFADevicePolicy_Mobile_IntegrityDetectionErrors
=== RUN   TestAccMFADevicePolicy_Mobile_BadMFADevicePolicyErrors
=== PAUSE TestAccMFADevicePolicy_Mobile_BadMFADevicePolicyErrors
=== RUN   TestAccMFADevicePolicy_Mobile_Minimal
=== PAUSE TestAccMFADevicePolicy_Mobile_Minimal
=== RUN   TestAccMFADevicePolicy_Mobile_Change
=== PAUSE TestAccMFADevicePolicy_Mobile_Change
=== RUN   TestAccMFADevicePolicy_Totp_Full
=== PAUSE TestAccMFADevicePolicy_Totp_Full
=== RUN   TestAccMFADevicePolicy_Totp_Minimal
=== PAUSE TestAccMFADevicePolicy_Totp_Minimal
=== RUN   TestAccMFADevicePolicy_Totp_Change
=== PAUSE TestAccMFADevicePolicy_Totp_Change
=== RUN   TestAccMFADevicePolicy_FIDO2_Full
=== PAUSE TestAccMFADevicePolicy_FIDO2_Full
=== RUN   TestAccMFADevicePolicy_FIDO2_Minimal
=== PAUSE TestAccMFADevicePolicy_FIDO2_Minimal
=== RUN   TestAccMFADevicePolicy_FIDO2_Change
=== PAUSE TestAccMFADevicePolicy_FIDO2_Change
=== RUN   TestAccMFADevicePolicy_DataModel
=== PAUSE TestAccMFADevicePolicy_DataModel
=== RUN   TestAccMFADevicePolicy_BadParameters
=== PAUSE TestAccMFADevicePolicy_BadParameters
=== RUN   TestAccMFADevicePolicy_DeleteDependentSOPFinalAction
=== PAUSE TestAccMFADevicePolicy_DeleteDependentSOPFinalAction
=== CONT  TestAccMFADevicePolicy_RemovalDrift
=== CONT  TestAccMFADevicePolicy_Mobile_BadMFADevicePolicyErrors
=== CONT  TestAccMFADevicePolicy_FIDO2_Full
=== CONT  TestAccMFADevicePolicy_Totp_Full
=== CONT  TestAccMFADevicePolicy_Totp_Change
=== CONT  TestAccMFADevicePolicy_Totp_Minimal
=== CONT  TestAccMFADevicePolicy_Voice_Change
=== CONT  TestAccMFADevicePolicy_DataModel
=== CONT  TestAccMFADevicePolicy_DeleteDependentSOPFinalAction
=== CONT  TestAccMFADevicePolicy_Mobile_Minimal
=== CONT  TestAccMFADevicePolicy_FIDO2_Minimal
=== CONT  TestAccMFADevicePolicy_Email_Change
=== CONT  TestAccMFADevicePolicy_Mobile_IntegrityDetectionErrors
=== CONT  TestAccMFADevicePolicy_BadParameters
=== CONT  TestAccMFADevicePolicy_Mobile_Full
=== CONT  TestAccMFADevicePolicy_Mobile_Change
--- PASS: TestAccMFADevicePolicy_Mobile_IntegrityDetectionErrors (8.59s)
=== CONT  TestAccMFADevicePolicy_SMS_Change
--- PASS: TestAccMFADevicePolicy_Totp_Minimal (9.67s)
=== CONT  TestAccMFADevicePolicy_Voice_Minimal
--- PASS: TestAccMFADevicePolicy_FIDO2_Minimal (10.00s)
=== CONT  TestAccMFADevicePolicy_Voice_Full
--- PASS: TestAccMFADevicePolicy_Mobile_Minimal (10.04s)
=== CONT  TestAccMFADevicePolicy_SMS_Full
--- PASS: TestAccMFADevicePolicy_FIDO2_Full (12.36s)
=== CONT  TestAccMFADevicePolicy_SMS_Minimal
--- PASS: TestAccMFADevicePolicy_Totp_Full (13.61s)
=== CONT  TestAccMFADevicePolicy_Email_Minimal
--- PASS: TestAccMFADevicePolicy_DeleteDependentSOPFinalAction (15.17s)
=== CONT  TestAccMFADevicePolicy_NewEnv
--- PASS: TestAccMFADevicePolicy_Mobile_BadMFADevicePolicyErrors (15.27s)
=== CONT  TestAccMFADevicePolicy_Email_Full
--- PASS: TestAccMFADevicePolicy_Mobile_Full (15.92s)
=== CONT  TestAccMFADevicePolicy_FIDO2_Change
--- PASS: TestAccMFADevicePolicy_BadParameters (18.31s)
--- PASS: TestAccMFADevicePolicy_Voice_Minimal (10.08s)
--- PASS: TestAccMFADevicePolicy_SMS_Minimal (8.64s)
--- PASS: TestAccMFADevicePolicy_SMS_Full (11.72s)
--- PASS: TestAccMFADevicePolicy_Email_Change (22.12s)
--- PASS: TestAccMFADevicePolicy_Totp_Change (22.29s)
--- PASS: TestAccMFADevicePolicy_Voice_Full (12.36s)
--- PASS: TestAccMFADevicePolicy_Email_Minimal (8.89s)
--- PASS: TestAccMFADevicePolicy_Voice_Change (22.51s)
--- PASS: TestAccMFADevicePolicy_Email_Full (9.08s)
--- PASS: TestAccMFADevicePolicy_SMS_Change (17.59s)
--- PASS: TestAccMFADevicePolicy_Mobile_Change (26.38s)
--- PASS: TestAccMFADevicePolicy_FIDO2_Change (13.54s)
--- PASS: TestAccMFADevicePolicy_DataModel (34.61s)
--- PASS: TestAccMFADevicePolicy_RemovalDrift (52.29s)
--- PASS: TestAccMFADevicePolicy_NewEnv (41.90s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/mfa 58.651s

@patrickcping patrickcping added the status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change service/mfa PingOne MFA status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK type/housekeeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant