Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: migrate br github actions to tidb #27598

Merged
merged 40 commits into from Sep 9, 2021
Merged

br: migrate br github actions to tidb #27598

merged 40 commits into from Sep 9, 2021

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Aug 26, 2021 •
edited by tisonkun

What problem does this PR solve?

Problem Summary:
After BR merged into TiDB, The github actions didn't migrate immediately.
This action may not work after gcs pkg br/compatible_test.yml

What is changed and how it works?

This closes #27624

What's Changed:
This PR tries to migrate origin br/build.yml and br/compatible_test.yml to tidb github actions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 26, 2021 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2021
@3pointer
Copy link
Contributor Author

/rebuild

kennytm
kennytm reviewed Aug 30, 2021
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

go.mod Outdated Show resolved Hide resolved
go.mod Outdated
@@ -3,8 +3,7 @@ module github.com/pingcap/tidb
go 1.16

require (
cloud.google.com/go v0.54.0 // indirect
cloud.google.com/go/storage v1.6.0
cloud.google.com/go/storage v1.16.1-0.20210826124857-08169baa564d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps you need to keep the comment about the failing br_gcs test, until googleapis/google-cloud-go#4609 is released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.16.1 released

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/googleapis/google-cloud-go/releases/tag/storage/v1.16.1

@3pointer
Copy link
Contributor Author

3pointer commented Sep 2, 2021

/run-integration-tests

@3pointer
Copy link
Contributor Author

3pointer commented Sep 2, 2021

/run-integration-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 9, 2021
@3pointer
Copy link
Contributor Author

3pointer commented Sep 9, 2021

/run-integration-tests

@3pointer
Copy link
Contributor Author

3pointer commented Sep 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3326d36

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 9, 2021
@ti-chi-bot
Copy link
Member

@3pointer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@glorv
Copy link
Contributor

glorv commented Sep 9, 2021

/build

@ti-chi-bot ti-chi-bot merged commit b8d806b into pingcap:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@glorv glorv glorv approved these changes

Assignees
No one assigned
Labels
release-note-none size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate GitHub Actions workflows of BR subtree
4 participants
@3pointer @ti-chi-bot @glorv @kennytm