Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add support for discounts #321

Open
wants to merge 2 commits into
base: original
Choose a base branch
from
Open

ENH: add support for discounts #321

wants to merge 2 commits into from

Conversation

otistamp
Copy link

@otistamp otistamp commented Mar 7, 2017

No description provided.

meshy
meshy reviewed Mar 7, 2017
View reviewed changes
pinax/stripe/actions/customers.py
'trial_end': trial_end,
}
if coupon:
kwargs.update({'coupon': coupon})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is similar to a change I've got in my PR.

Perhaps we'd both benefit from all kwargs from this function being passed into stripe.Customer.create...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, although the main purpose of the PR is to support discount syncing on customer and subscription models.

@coveralls
Copy link

coveralls commented Mar 7, 2017 •
edited

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 2195800 on otistamp:discounts into ec14b69 on pinax:master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 7, 2017 •
edited

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 2195800 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

coveralls commented Mar 7, 2017 •
edited

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 1800a9b on otistamp:discounts into ec14b69 on pinax:master.

7 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 1800a9b on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 1800a9b on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 1800a9b on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 1800a9b on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 1800a9b on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 1800a9b on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 98.625% when pulling 1800a9b on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

coveralls commented Mar 7, 2017 •
edited

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e04f68d on otistamp:discounts into ec14b69 on pinax:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e04f68d on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e04f68d on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e04f68d on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e04f68d on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e04f68d on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

coveralls commented Mar 7, 2017 •
edited

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e9659d9 on otistamp:discounts into ec14b69 on pinax:master.

8 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e9659d9 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e9659d9 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e9659d9 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e9659d9 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e9659d9 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e9659d9 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e9659d9 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling e9659d9 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling 52b4abe on otistamp:discounts into ec14b69 on pinax:master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 7, 2017 •
edited

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling 52b4abe on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

coveralls commented Mar 7, 2017 •
edited

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling 84337f4 on otistamp:discounts into ec14b69 on pinax:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 98.324% when pulling 84337f4 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

22 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 98.175% when pulling ec1e1f8 on otistamp:discounts into ec14b69 on pinax:master.

@paltman
Copy link
Member

paltman commented Apr 14, 2017

Please add tests. I'd like to keep master at 100% coverage. Thanks!

@otistamp
ENH: add support for discounts
21da1b5 
ENH: add apply discount to discount model

ENH: add discount migration

BUG: fix discount key error when no discount exists

BUG: convert start and end of discount to tstamps

BUG: fix coupon fetch for discount creation

BUG: remove stripe_id and created_at from Discount

BUG: make discount relationships one to one

BUG: migration reflection of discount one to one fields

BUG: do not apply discount if end is in the past

BUG: change coupon to foreign key on discount

BUG: pass customer obj to discount creation instead of stripe customer

BUG: update the same discount on sync since there can be only one per customer and sub

CLN: bump discount migration up one since 7 is taken in upstream

CLN: delete older discount migration

BUG: discount migration dependent on coupon migration

BUG: discount migration dependent on new 7th migration

BUG: fix get or create logic for discount syncing

ENH: add quantity to create customer
@otistamp
ENH: fix jsonfield dependency breaking 1.11
5214117
@paltman paltman added the Original The original full pinax-stripe version with cached models and actions service layer label Nov 26, 2021
@paltman paltman changed the base branch from master to 4.x November 26, 2021 16:20
@paltman paltman changed the base branch from 4.x to original November 26, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meshy meshy meshy left review comments

Assignees
No one assigned
Labels
needs-tests Original The original full pinax-stripe version with cached models and actions service layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@otistamp @coveralls @paltman @meshy