-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add psycopg3 support to runmailer_pg #177
Conversation
Hi @jsmits thanks for the PR. Could you give me some context and a high level description about what is going on here? Thanks! |
Sure, no problem. I tried to run the runmailer_pg command in my latest django project and it crashed because my project uses psycopg3. Runmailer_pg expects psycopg2 still. This PR makes it seamlessly run with both, so if you have psycopg3 installed, it will use that, and if you have pscyopg2 installed, it will use that, just like it did before. Probably other people will run into this as well when they start using django with psycopg3 and the current django-mailer’s runmailer_pg. |
Can you explain why this isn't just case of changing imports? Specifically what is different in psycopg3 that requires changes? Thanks! |
Basically two things:
|
Great, thank you! |
Released just now in 2.3.2 |
Awesome, thanks a lot! |
Changes proposed in this PR:
Tips for an ideal PR
setup.py
(Pinax uses SemVer)Change Log
has been updatedAUTHORS
file