Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_musicbox.sh #355

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

jpswade
Copy link
Contributor

@jpswade jpswade commented Feb 21, 2016

Lot of changes to get it to work!

Lot of changes to get it to work!
@kingosticks
Copy link
Member

Yes, what is checked in here is very old and not much use to anyone in it's current form. I should have posted a note to that effect to prevent anyone trying to use it, or spend time working on it.

I've yet to push the new version, which incorporates many of these fixes. I don't think there is much point working to try and merge this, only to then blow most of it away.

I very much appreciate anyone taking the time to submit pull requests. We don't get a lot of them and it's probably why this hasn't really been an issue before. I merged the other two because they were both still applicable and simple enough to incorporate.

@jpswade
Copy link
Contributor Author

jpswade commented Feb 21, 2016

@kingosticks
Copy link
Member

Thanks, a real eye-opener.

@jpswade
Copy link
Contributor Author

jpswade commented Feb 22, 2016

@kingosticks does that mean we can expect an update from you soon?

@kingosticks
Copy link
Member

My plans to push an updated branch have not changed, i.e. as soon as I can.

@jpswade
Copy link
Contributor Author

jpswade commented Feb 26, 2016

Is there some kind of impediment?

On Tue, 23 Feb 2016 13:00 Nick Steel notifications@github.com wrote:

My plans to push an updated branch have not changed, i.e. as soon as I
can.


Reply to this email directly or view it on GitHub
#355 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants