New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass metadata to gotenberg-chromium processor #66
base: 1.x
Are you sure you want to change the base?
Pass metadata to gotenberg-chromium processor #66
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
ab86471
to
0d5a0b1
Compare
Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
@kingjia90 on v2.2.0 the https://github.com/gotenberg/gotenberg-php/blob/main/src/MultipartFormDataModule.php#L92 |
@muratbinerbay @kingjia90 The formValue is only in 1.1.8 public. |
So many plot twists 😄 Thank you for the changes. |
@kingjia90 Yes PhpStan doesn't want the formValue method because it is protected in 2.2. But it isn't reachable there. |
Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
@blankse @kingjia90 do we want to try something like ReflectionMethod. Seems rather excessive to me but I'm willing to try it :) |
Doesn't work :( I think we need the same construct like in pimcore/pimcore. We have there a own phpstan config for lowest with So we can create a phpstan baseline with the highest dependencies. |
Of course, we could also process the metadata with version 2.2 only, if that is an alternative :) |
would also be acceptable in my opinion, @kingjia90 what do you think? |
Hi @kingjia90 @fashxp, just wanted to ping you to check if I can go ahead and make the metadata available only for gotenberg-php:2.2+ ? |
This will let us pass metadata to the PDF file like title, author, copyright, and creation date.
Documentation links: