Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Github Action] Setup codeception #16

Merged
merged 31 commits into from
Apr 25, 2023
Merged

[Github Action] Setup codeception #16

merged 31 commits into from
Apr 25, 2023

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Apr 14, 2023 •
edited

Resolves #3

Testing

  • the creation and save of print document types (print page/container)
  • saving the configs
  • test each processor by generating a pdf with different orientation (landscape/portrait), asserted by page measurements getted from pdfinfo cli command
  • asserting some part of the content of the pdf via pdfToText feature from Ghostscript

@kingjia90 kingjia90 added the Task label Apr 14, 2023
@kingjia90
add adminbunle registration
759e1b1 
fix setup-pimcore-environment.sh
@kingjia90
task: various fixes
d89d4f5 
refine orientation check
revert some testing changes
change system settings write/read target to symfony-config
@kingjia90 kingjia90 marked this pull request as ready for review April 19, 2023 15:57
@aryaantony92 aryaantony92 self-assigned this Apr 20, 2023
@aryaantony92
Copy link
Contributor

Remove unused files https://github.com/pimcore/web-to-print-bundle/blob/deeac30ca69b5a1058552186a66e6ce15fdb7b80/.github/ci/files/config/packages/test/unittest.yaml and https://github.com/pimcore/web-to-print-bundle/blob/deeac30ca69b5a1058552186a66e6ce15fdb7b80/tests/Unit/_bootstrap.php

aryaantony92
aryaantony92 reviewed Apr 24, 2023
View reviewed changes
tests/Model/Processor/ProcessorTest.php Outdated Show resolved Hide resolved
tests/Model/Processor/ProcessorTest.php Outdated Show resolved Hide resolved
kingjia90 and others added 3 commits April 24, 2023 16:24
@kingjia90 @aryaantony92
Apply suggestions from code review
fb11a43 
Co-authored-by: aryaantony92 <97134765+aryaantony92@users.noreply.github.com>
@aryaantony92
Remove unused files
f2c04e5
@aryaantony92
Readd Unit folder
5a24a0c
@aryaantony92 aryaantony92 merged commit 320c381 into 1.x Apr 25, 2023
6 checks passed
@aryaantony92 aryaantony92 deleted the setup_codeception branch April 25, 2023 07:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
@kingjia90 kingjia90 added this to the 1.0.0 milestone May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aryaantony92 aryaantony92 aryaantony92 left review comments

Assignees

@aryaantony92 aryaantony92

Labels
Task
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Setup codeception
3 participants
@kingjia90 @aryaantony92 @fashxp