QuantityValue webservice bugfix #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctually exists otherwise a problem will result if units get deleted
|
Many thanks, maybe we should also think about a proactive cleanup task as part of the maintenance? |
|
yes, the cleanup task might be a good idea |
|
or just use foreign key constraints? |
|
technically possible, was considering this but wasn't sure if this really performs ... |
|
https://dev.mysql.com/doc/refman/5.6/en/create-table-foreign-keys.html |
|
maybe open a seperate "improvement" ticket ? |
|
of course, either for the foreign key or the cleanup task. Can you? |
|
done, see #3376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A check is needed whether the unit actually exists otherwise a problem will result if units get deleted as the unit ID might be still in the database.