Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation Container with OPCache creates infinite loop #16989

Open
wants to merge 1 commit into
base: 11.2
Choose a base branch
from
Open

Navigation Container with OPCache creates infinite loop #16989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Navigation/Container.php
View file
Open in desktop
Expand Up @@ -545,12 +545,12 @@
return $this->hasPages();
}

public function getChildren(): ?Page
public function getChildren(): ?static
{
$hash = key($this->_index);

if (isset($this->_pages[$hash])) {
return $this->_pages[$hash];

Check failure on line 553 in lib/Navigation/Container.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.3, lowest, false) 

Method Pimcore\Navigation\Container::getChildren() should return static(Pimcore\Navigation\Container)|null but returns Pimcore\Navigation\Page.

Check failure on line 553 in lib/Navigation/Container.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.3, highest, false) 

Method Pimcore\Navigation\Container::getChildren() should return static(Pimcore\Navigation\Container)|null but returns Pimcore\Navigation\Page.

Check failure on line 553 in lib/Navigation/Container.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.2, lowest, false) 

Method Pimcore\Navigation\Container::getChildren() should return static(Pimcore\Navigation\Container)|null but returns Pimcore\Navigation\Page.

Check failure on line 553 in lib/Navigation/Container.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.2, highest, false) 

Method Pimcore\Navigation\Container::getChildren() should return static(Pimcore\Navigation\Container)|null but returns Pimcore\Navigation\Page.

Check failure on line 553 in lib/Navigation/Container.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.1, lowest, false) 

Method Pimcore\Navigation\Container::getChildren() should return static(Pimcore\Navigation\Container)|null but returns Pimcore\Navigation\Page.

Check failure on line 553 in lib/Navigation/Container.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.1, highest, false) 

Method Pimcore\Navigation\Container::getChildren() should return static(Pimcore\Navigation\Container)|null but returns Pimcore\Navigation\Page.
}

return null;
Expand Down