Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fix wysiwyg max character, soften the warning and add visual helper #16975

Merged
merged 2 commits into from May 3, 2024
Merged

[Bug]: Fix wysiwyg max character, soften the warning and add visual helper #16975

merged 2 commits into from May 3, 2024

Conversation

kingjia90
Copy link
Contributor

Changes in this pull request

Resolves #16630

Additional info

Before PR
image

After PR
image
which is more similar to textArea
image

@kingjia90
improve title and translation
a8ed1a3 
fix max character, soften the warning and add visual helper
@kingjia90 kingjia90 added the Bug label Apr 22, 2024
@kingjia90 kingjia90 added this to the 11.2.3 milestone Apr 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited by robertSt7

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 linked an issue Apr 22, 2024 that may be closed by this pull request
[Bug]: Wysiwyg editors all use the same max length (max characters) #16630
Closed
@kingjia90 kingjia90 mentioned this pull request Apr 22, 2024
Closed
@kingjia90 kingjia90 modified the milestones: 11.2.3, 11.2.4 Apr 23, 2024
@kingjia90 @robertSt7
Update bundles/TinymceBundle/public/js/editor.js
5791ea2 
Co-authored-by: robertSt7 <104770750+robertSt7@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@robertSt7 robertSt7 merged commit 5dc4513 into 11.2 May 3, 2024
17 checks passed
@robertSt7 robertSt7 deleted the fix-char-count-wyiwyg branch May 3, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertSt7 robertSt7 robertSt7 left review comments

Assignees

@robertSt7 robertSt7

Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
11.2.4
Development

Successfully merging this pull request may close these issues.

[Bug]: Wysiwyg editors all use the same max length (max characters)
3 participants
@kingjia90 @robertSt7 @wisconaut