Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SimpleBackendSearchBundle] Fix Data setters (nullable params) #16970

Merged

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Apr 21, 2024

Changes in this pull request

See #15943
Resolves #16965

Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@lukmzig lukmzig self-assigned this May 3, 2024
@lukmzig lukmzig added this to the 11.2.4 milestone May 3, 2024
@lukmzig lukmzig added the Bug label May 3, 2024
@lukmzig
Copy link
Contributor

lukmzig commented May 7, 2024

@blankse can you please remove the changes here?
https://github.com/pimcore/pimcore/pull/16970/files#diff-464ea7ee8142d9960b6349fb040c177d818aefdd437151c3417ff72b04fced26

we discussed this internally and we will have to investigate the issue deeper as this should generally not happen.
Then we can merge your PR, thank you!

@blankse
Copy link
Contributor Author

blankse commented May 7, 2024

@lukmzig I splitted the PR to #17020

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@lukmzig
Copy link
Contributor

lukmzig commented May 7, 2024

@blankse thank you!

@lukmzig lukmzig merged commit 78da4b8 into pimcore:11.2 May 7, 2024
17 checks passed
@blankse blankse deleted the fix_simple_backend_search_data_setters branch May 7, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants