Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC - Improve editable documentation and make twig syntax more consistent #16969

Merged
merged 4 commits into from Apr 26, 2024

Conversation

skoch98
Copy link
Contributor

@skoch98 skoch98 commented Apr 21, 2024

Changes in this pull request

This week I had a call with a developer from the Pimcore GitHub discussions who I have been helping and among other questions he was troubled with the configuration of the editables.

So I've looked at a handful and tested what's possible and added the configuration to the documentation.
I also fixed twig syntax / make it more consistent for the examples in "doc/03_Documents/01_Editables/02_Areablock/".

Copy link

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@skoch98 skoch98 changed the title Improve editable documentation and make twig syntax more consistent DOC - Improve editable documentation and make twig syntax more consistent Apr 21, 2024
Copy link

sonarcloud bot commented Apr 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@markus-moser markus-moser self-assigned this Apr 26, 2024
@markus-moser markus-moser added this to the 11.3.0 milestone Apr 26, 2024
@markus-moser markus-moser merged commit 9b560dc into pimcore:11.x Apr 26, 2024
5 checks passed
@markus-moser
Copy link
Contributor

Nice, thanks a lot 💯

@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants