Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Composer] Remove unused rybakit/twig-deferred-extension dependency #16966

Open
wants to merge 3 commits into
base: 11.x
Choose a base branch
from
Open

[Composer] Remove unused rybakit/twig-deferred-extension dependency #16966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a88f13f
[Composer] Remove unused `rybakit/twig-deferred-extension` dependency
blankse Apr 19, 2024
91f97d7
Remove DeferredExtension service
blankse Apr 19, 2024
b4e22c5
Add service to upgrade notes
blankse Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions bundles/CoreBundle/config/templating_twig.yaml
View file
Open in desktop
Expand Up @@ -67,11 +67,6 @@ services:

Pimcore\Twig\Extension\ImageThumbnailExtension: ~

# the deferred extension is needed for placeholder helpers to work
# as otherwise the placeholder block would be rendered before any
# content was added (e.g. headTitle)
Twig\DeferredExtension\DeferredExtension: ~

Pimcore\Twig\Sandbox\SecurityPolicy:
arguments:
$allowedTags: '%pimcore.templating.twig.sandbox_security_policy.tags%'
Expand Down
1 change: 0 additions & 1 deletion composer.json
View file
Open in desktop
Expand Up @@ -73,7 +73,6 @@
"pear/net_url2": "^2.2",
"phpoffice/phpspreadsheet": "^1.24",
"presta/sitemap-bundle": "^3.3",
"rybakit/twig-deferred-extension": "^3.0",
"sabre/dav": "^4.1.2",
"scheb/2fa-bundle": "^6.0",
"scheb/2fa-google-authenticator": "^6.0",
Expand Down
3 changes: 3 additions & 0 deletions doc/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md
View file
Open in desktop
Expand Up @@ -6,6 +6,9 @@
- Unused setting `general.language` has been deprecated.
#### [Listing]
- The methods `setOrder()` and `setOrderKey()` throw an `InvalidArgumentException` if the parameters are invalid now.
#### [Twig Deferred Extension]
- Removed `rybakit/twig-deferred-extension` dependency and `Twig\DeferredExtension\DeferredExtension` service.
If you use deferred twig blocks, please add the dependency to your own `composer.json` and the service to your own `service.yaml`.

## Pimcore 11.2.0
### Elements
Expand Down