[Bug]: Fix pdf scanner #16956
Draft
[Bug]: Fix pdf scanner #16956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
|
kingjia90
commented
Apr 17, 2024
| $asset->setCustomSetting($asset::CUSTOM_SETTING_PDF_SCAN_STATUS, PdfScanStatus::UNSAFE->value); | ||
| $note = 'unsafe'; | ||
| } | ||
| $asset->save(['versionNote' => 'PDF scan result:' . $note]); |
There was a problem hiding this comment.
mhhh, this could be bad, if by uploading a pdf that takes 5 seconds to check, and within that time, it's replaced by a new one that takes 1 second, by the time it finishes the first task, it would add a newer version with a earlier date than the creation date of the latest one, or things like that.
That's probably why it uses saveAsset() that avoid Versioning.
Is it async or sync?
Is it necessary vernsioNote? could it be moved to metadata?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #16318
Requires pimcore/admin-ui-classic-bundle#498
Additional info
It seems the problem was that the sanitization would be re-dispatched on every reload and at least every 5 seconds, because the in progress is not saved and was always null
Also if processBackground is false, it's appearing as in progress all the time, due to the line above it.