Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new option in workflow notificationSettings to ensure that notifications are also sent to inactive users. #16904

Open
wants to merge 2 commits into
base: 11.2
Choose a base branch
from

Conversation

rahul-pim-dev
Copy link

Added a new option in workflow notificationSettings to ensure that notifications are also sent to inactive users.

see : #16867

Copy link

github-actions bot commented Apr 5, 2024

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@markus-moser
Copy link
Contributor

@rahul-pim-dev Thanks a lot, could you please sign the CLA?

I would call the current behaviour more like a bug. The workflow engine should not send notifications to inactive users. I would say let's not make this configurable. I would call this more like a "security leak". When someone deactivates a user this user should not get any notifications anymore (and therefore receive potentially internal information). If someone wants to send notifications to users without real access to the Pimcore backend it would be possible to add a user without rights but activate it.

@markus-moser markus-moser self-assigned this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants