Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Prevent db errors on index updates on classes rebuild #16871

Merged
merged 7 commits into from May 3, 2024
Merged

[Improvement] Prevent db errors on index updates on classes rebuild #16871

merged 7 commits into from May 3, 2024

Commits on Apr 22, 2024

  1. [db-errors] check if index exists, before adding or remove it

    @lukadschaak
    lukadschaak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    fcb1195 View commit details
    Browse the repository at this point in the history

  2. [db-errors] fix php code style by removing that foreach construct

    @lukadschaak
    lukadschaak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3c0995a View commit details
    Browse the repository at this point in the history

  3. [db-errors] use caps for SQL syntax 

    Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
    @lukadschaak @jdreesen
    lukadschaak and jdreesen committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    656ae2e View commit details
    Browse the repository at this point in the history

  4. [db-errors] use $indexName instead of $columnName, because $columnNam… 

    …e can contain quotes
    @lukadschaak
    lukadschaak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9802b1c View commit details
    Browse the repository at this point in the history

  5. [db-errors] fix typing of index exists db return value

    @lukadschaak
    lukadschaak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ee057ea View commit details
    Browse the repository at this point in the history

  6. [db-errors] refactor some $columnName variable to $indexName

    @lukadschaak
    lukadschaak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    fde10b3 View commit details
    Browse the repository at this point in the history

  7. [db-errors] chore: remove unused imports

    @lukadschaak
    lukadschaak committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    afd06cb View commit details
    Browse the repository at this point in the history