Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foreign key to unit fields to cleanup if unit is deleted #16836

Open
wants to merge 4 commits into
base: 11.x
Choose a base branch
from
Open

Add foreign key to unit fields to cleanup if unit is deleted #16836

wants to merge 4 commits into from

Conversation

matthiashamacher
Copy link
Contributor

Changes in this pull request

Resolves #3376

@matthiashamacher
Add foreign key to unit fields to cleanup if unit is deleted
66787d1 
Signed-off-by: Matthias Hamacher <m.hamacher@basecom.de>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 23, 2024 •
edited by mcop1

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@matthiashamacher
Fix phpstan & sonarcloud issues
8b93c50 
Signed-off-by: Matthias Hamacher <m.hamacher@basecom.de>
@matthiashamacher
Fix sonarcloud issues
0f8cbf8 
Signed-off-by: Matthias Hamacher <m.hamacher@basecom.de>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mcop1 mcop1 self-requested a review April 12, 2024 07:48
@mcop1 mcop1 self-assigned this Apr 12, 2024
@mcop1 mcop1 removed their request for review April 12, 2024 07:48
@mcop1 mcop1 added this to the 11.3.0 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mcop1 mcop1

Labels
Improvement Pimcore:ToDo
Projects
None yet
Milestone
11.3.0
Development

Successfully merging this pull request may close these issues.

QuantityValue: clean up data on deletion of units
3 participants
@matthiashamacher @mcop1 @wisconaut