Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractPimcoreBundle should extend AbstractBundle #16704

Open
wants to merge 2 commits into
base: 11.x
Choose a base branch
from

Conversation

DzemalBecirevic
Copy link
Contributor

@DzemalBecirevic DzemalBecirevic commented Feb 29, 2024

AbstractPimcoreBundle should extends AbstractBundle to enable support for prependExtension.

https://symfony.com/blog/new-in-symfony-6-1-simpler-bundle-extension-and-configuration

Changes in this pull request

Resolves #

Additional info

Copy link

Review Checklist

  • Target branch (11.1 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@DzemalBecirevic
Copy link
Contributor Author

Im not sure why all the tests fail but I did the change locally and is working as expected.

Also not sure if this is a bug fix or a feature/maintenance fix.

@DzemalBecirevic
Copy link
Contributor Author

I've noticed that this has caused problems in more cases then one where extending/using configuration from Bundle A in Bundle B is no longer working as expected.

I still think this should be changed but I guess it menas that all pimcore bundles have to be reviewed and updated, to my understanding, to use prependExtension method for extending/setting other bundles configuration.

Please correct me or link me to resources describing how this is done today as I could not find any other solution then using prependExtension.

Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (kingjia90)[https://github.com/kingjia90]
@DzemalBecirevic
You can retrigger this bot by commenting recheck in this Pull Request

@kingjia90 kingjia90 added this to the 11.3.0 milestone Apr 19, 2024
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants