New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractPimcoreBundle should extend AbstractBundle #16704
base: 11.x
Are you sure you want to change the base?
AbstractPimcoreBundle should extend AbstractBundle #16704
Conversation
Review Checklist
|
Im not sure why all the tests fail but I did the change locally and is working as expected. Also not sure if this is a bug fix or a feature/maintenance fix. |
I've noticed that this has caused problems in more cases then one where extending/using configuration from Bundle A in Bundle B is no longer working as expected. I still think this should be changed but I guess it menas that all pimcore bundles have to be reviewed and updated, to my understanding, to use prependExtension method for extending/setting other bundles configuration. Please correct me or link me to resources describing how this is done today as I could not find any other solution then using prependExtension. |
Quality Gate passedIssues Measures |
…core-bundles-extend-abstract-bundle
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
Quality Gate passedIssues Measures |
AbstractPimcoreBundle should extends AbstractBundle to enable support for prependExtension.
https://symfony.com/blog/new-in-symfony-6-1-simpler-bundle-extension-and-configuration
Changes in this pull request
Resolves #
Additional info