DocumentRenderer: setCurrentSite to generate correct path of document in static page generator

[melissakittl]

Problem

Static page generation via cli does not consider current site, what causes wrong link generation of documents in the generated static files.

Expected behavior

When using sites in pimcore, the static page files contains correct generated links by pimcore_linketc., like /en/products.

Actual behavior

When running bin/console pimcore:maintenance --job=documents_static_page_generate or bin/console pimcore:documents:generate-static-pages static page files are generated with links like /my-site/en/products instead of /en/products

Changes in this pull request

Set current site in DocumentRenderer, if site was found, to ensure correct link generation

[github-actions]

Review Checklist

• Target branch (11.1 for bug fixes, others 11.x)
• Tests (if it's testable code, there should be a test for it - get help)
• Docs (every functionality needs to be documented, see here)
• Migration incl. install.sql (e.g. if the database schema changes, ...)
• Upgrade notes (deprecations, important information, migration hints, ...)
• Label
• Milestone

[melissakittl]

@kingjia90
This is still relevant for static pages to work properly.

[kingjia90]

@melissakittl Sorry for the PR getting closed, this was not intentional, as soon as i deleted the base branch 11.1 (due 11.2 being released), it automatically closed the PRs targeting 11.1.
Re-opening all

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[melissakittl]

Hi @kingjia90,
any news about this?

[kingjia90]

Thank you for the PR, haven't yet dig into it, but on a first look, it seems that it would be "safer" to have it under

if ($attributes['pimcore_static_page_generator'] ?? false) {
   if (isset($site)){
      Site::setCurrentSite($site);
      ...

not quite sure how it worked before for other cases where this render is used and if your suggested changes fixes an overall broken behavior or if it's the specific static page case are affected.