Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix document resolution in DocumentRouteHandler #16512

Closed
wants to merge 1 commit into from
Closed

Fix document resolution in DocumentRouteHandler #16512

wants to merge 1 commit into from

Conversation

alexej-d
Copy link

Changes in this pull request

Resolves #16420

Additional info

I am not sure if this has any side effects, but my test did not show any repercussions.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.1 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@brusch brusch deleted the branch pimcore:11.1 January 29, 2024 09:51
@brusch brusch closed this Jan 29, 2024
@brusch brusch reopened this Jan 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@robertSt7 robertSt7 added the Bug label Feb 1, 2024
@kingjia90 kingjia90 linked an issue Feb 13, 2024 that may be closed by this pull request
[Bug]: Having a pretty URL, that matches the key of a document link leads to infinite redirects on multisite environments #16420
Open
@kingjia90 kingjia90 self-assigned this Feb 26, 2024
@kingjia90 kingjia90 deleted the branch pimcore:11.1 March 12, 2024 15:13
@kingjia90 kingjia90 closed this Mar 12, 2024
@alexej-d alexej-d deleted the patch-2 branch March 12, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kingjia90 kingjia90

Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
No milestone
6 participants
@alexej-d @CLAassistant @brusch @kingjia90 @robertSt7 @wisconaut