Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wysiwyg editors all use the same max length (max characters) #16630

Closed
notsure opened this issue Feb 19, 2024 · 4 comments · Fixed by #16975
Closed

[Bug]: Wysiwyg editors all use the same max length (max characters) #16630

notsure opened this issue Feb 19, 2024 · 4 comments · Fixed by #16975
Assignees
Milestone

Comments

@notsure
Copy link

notsure commented Feb 19, 2024

Pimcore version

11.1.5

Steps to reproduce

  1. Create a new or open an existing data object class definition
  2. Edit or add a new wysiwyg field
  3. Add some max characters value (eg. 10)
  4. Add one more wysiwyg field without a max length
  5. Visit the data object or create a new one
  6. Try to enter more than 10 chars to the field and you will see an error (which is fine, by the way ESC should close this window, which it doesn't)
  7. Try to enter more than 10 chars in the second field and you will see the same error.
  8. ONE MORE THING: this same error will now also occur in any other wysiwyg in any other editor.

Actual Behavior

It seems like the max chars config is used for all wysiwyg fields across the page.

This leads to the issue, that there is a max length error in all wysiwyg fields no matter if a max length is defined for them or not.

Expected Behavior

Only the wysiwyg field with a defined max length should throw the error.

@notsure notsure added the Bug label Feb 19, 2024
@wisconaut wisconaut added this to the 11.1.6 milestone Feb 22, 2024
@wisconaut wisconaut assigned kingjia90 and unassigned ibousfiha Feb 26, 2024
@kingjia90 kingjia90 modified the milestones: 11.1.6, 11.2.1, 11.2.2 Mar 12, 2024
@kingjia90 kingjia90 modified the milestones: 11.2.2, 11.2.3 Mar 26, 2024
@notsure
Copy link
Author

notsure commented Apr 16, 2024

Hi There,
any progress on this one?

best regards

@fashxp
Copy link
Member

fashxp commented Apr 16, 2024

we have it on our todo list, but there is no ETA yet.
a PR would speed things up certainly ;-)

@kingjia90
Copy link
Contributor

@notsure Thank you for reporting and your patience!

Please have a look at #16975 and give it a try, i have also considered the feedback that the error popup can't be closed by ESC, made it more less intrusive instead by highlighting the text area with a red border and text on hover (html title)

@kingjia90 kingjia90 modified the milestones: 11.2.3, 11.2.4 Apr 23, 2024
@kingjia90
Copy link
Contributor

Fixed by #16975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants