Pimcore 11 compatibility fixes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thx a lot - I merge it into #8 to see if PHPStan runs through |
markus-moser
added a commit
that referenced
this pull request
Mar 29, 2024
…bugs (#8) * Require ecommerce framework bundle to fix PHPStan * Update composer.json * Pimcore 11 compatibility fixes (#6) * fix(pimcore-11): Fix type declarations * fix(pimcore-11): Fix incorrect Authorization attribute for Guzzle * fix(pimcore-11): PHP 8: Check for keys that may not be present in response * feat(pimcore-11): rename config files * Fix PHPStan autoload * Fix PHPStan autoload * Fix PHPStan autoload --------- Co-authored-by: Lukas B <theill182@gmail.com>
|
@GNi33 It's now merged into the 2.x branch. Unfortunately it's impossible for me to test if it really works, so please let me know if you had the chance to test the 2.x branch. If it works I can release a 2.0 version. |
|
@markus-moser works fine so far for us in production as well as testSystem mode. We will continue to monitor it, but the basic use case of payment via the CopyAndPay API is looking good so far. |
|
@GNi33 Thanks a lot for your feedback, I released v2 now based on your work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few compatibility fixes for Pimcore 11.
For example, the PaymentProviderInstaller implementation of Pimcore 11 added typed properties, which this bundle does not have until now, causing exceptions when installing the bundle. Also, the way the bearer authorization is implemented does not work with the version of GuzzleHttp that Pimcore 11 uses.