Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Request::get with explicit input sources #405

Merged
merged 5 commits into from Apr 23, 2024
Merged

Replace Request::get with explicit input sources #405

merged 5 commits into from Apr 23, 2024

Conversation

lukmzig
Copy link
Contributor

@lukmzig lukmzig commented Apr 23, 2024

Resolves #299

@lukmzig lukmzig added the Task label Apr 23, 2024
@lukmzig lukmzig added this to the 1.9.0 milestone Apr 23, 2024
@lukmzig lukmzig self-assigned this Apr 23, 2024
@lukmzig lukmzig requested a review from Corepex April 23, 2024 09:36
Corepex
Corepex approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukmzig lukmzig merged commit 004673e into 1.x Apr 23, 2024
8 checks passed
@lukmzig lukmzig deleted the 299-replace-requestget-with-explicit-input-sources branch April 23, 2024 09:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Corepex Corepex Corepex approved these changes

Assignees

@lukmzig lukmzig

Labels
Task
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Replace Request::get with explicit input sources
2 participants
@lukmzig @Corepex