Added Structured Table Type #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
fashxp
requested changes
Jan 29, 2024
| */ | ||
| public function evaluateReturnType(string $inputType, int $index = null): string | ||
| { | ||
| return TransformationDataTypeService::DEFAULT_ARRAY; |
There was a problem hiding this comment.
we would need to introduce there an extra type which just allows assignment to structured table fields, like we have it for quantity value, gallery etc.
| 'languages' | ||
| 'languages', | ||
| 'table', | ||
| 'structuredTable' |
There was a problem hiding this comment.
should be moved to an extra type...
| if (empty($inputData)) { | ||
| return ""; | ||
| } | ||
| return (new StructuredTable($inputData))->getHtmlTable( |
There was a problem hiding this comment.
Why return a html table here?
Shouldn't be that in generateResultPreview, as for example here
| 'key' => $value, | ||
| 'label' => $label, | ||
| ]; | ||
| }, array_keys($inputData), array_keys(array_values($inputData)[0])), |
There was a problem hiding this comment.
$inputData might be empty/null ... will result in errors at this place.
|
@mybabysexy 🏓 did you already have a chance to take a look at my comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #101