Skip to content

Commit

Permalink
fix: PHP STAN
Browse files Browse the repository at this point in the history
  • Loading branch information
@lukmzig
lukmzig committed Apr 23, 2024
1 parent d7a5d2b commit bc13922
Showing 1 changed file with 27 additions and 27 deletions.
54 changes: 27 additions & 27 deletions src/Controller/ConfigDataObjectController.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public function getAction(
): JsonResponse {
$this->checkPermission(self::CONFIG_NAME);

$name = $request->query->getString('name');
$name = $request->query->get('name');
$config = $configurationPreparationService->prepareConfiguration($name);

return new JsonResponse(
Expand Down Expand Up @@ -193,7 +193,7 @@ public function uploadPreviewDataAction(Request $request)
throw new Exception('File it too big for preview file, please create a smaller one');
}

$this->previewService->writePreviewFile($request->query->getString('config_name'), $sourcePath, $this->getPimcoreUser());
$this->previewService->writePreviewFile($request->query->get('config_name'), $sourcePath, $this->getPimcoreUser());
@unlink($sourcePath);

return new JsonResponse(['success' => true]);
Expand Down Expand Up @@ -224,8 +224,8 @@ public function copyPreviewDataAction(
DataLoaderFactory $dataLoaderFactory
) {
try {
$configName = $request->request->getString('config_name');
$currentConfig = $request->request->getString('current_config');
$configName = $request->request->get('config_name');
$currentConfig = $request->request->get('current_config');

$config = $configurationPreparationService->prepareConfiguration($configName, $currentConfig);
$loader = $dataLoaderFactory->loadDataLoader($config['loaderConfig']);
Expand Down Expand Up @@ -279,8 +279,8 @@ public function loadDataPreviewAction(
InterpreterFactory $interpreterFactory,
Translator $translator
) {
$configName = $request->request->getString('config_name');
$currentConfig = $request->request->getString('current_config');
$configName = $request->request->get('config_name');
$currentConfig = $request->request->get('current_config');
$recordNumber = $request->request->getInt('record_number');

$dataPreview = null;
Expand Down Expand Up @@ -337,8 +337,8 @@ public function loadAvailableColumnHeadersAction(
ConfigurationPreparationService $configurationPreparationService,
InterpreterFactory $interpreterFactory
) {
$configName = $request->request->getString('config_name');
$currentConfig = $request->request->getString('current_config');
$configName = $request->request->get('config_name');
$currentConfig = $request->request->get('current_config');
$config = $configurationPreparationService->prepareConfiguration($configName, $currentConfig);

return new JsonResponse([
Expand Down Expand Up @@ -366,8 +366,8 @@ public function loadTransformationResultPreviewsAction(
InterpreterFactory $interpreterFactory,
ImportProcessingService $importProcessingService
) {
$configName = $request->request->getString('config_name');
$currentConfig = $request->request->getString('current_config');
$configName = $request->request->get('config_name');
$currentConfig = $request->request->get('current_config');
$recordNumber = $request->request->getInt('current_preview_record');

$config = $configurationPreparationService->prepareConfiguration($configName, $currentConfig);
Expand Down Expand Up @@ -417,12 +417,12 @@ public function calculateTransformationResultTypeAction(
) {
try {
$currentConfig = json_decode(
$request->request->getString('current_config'),
$request->request->get('current_config'),
true,
512,
JSON_THROW_ON_ERROR
);
$configName = $request->request->getString('config_name');
$configName = $request->request->get('config_name');
$mappingConfiguration = $factory->loadMappingConfigurationItem($configName, $currentConfig, true);

return new JsonResponse($importProcessingService->evaluateTransformationResultDataType($mappingConfiguration));
Expand All @@ -443,7 +443,7 @@ public function calculateTransformationResultTypeAction(
*/
public function loadDataObjectAttributesAction(Request $request, TransformationDataTypeService $transformationDataTypeService)
{
$classId = $request->query->getString('class_id');
$classId = $request->query->get('class_id');
if (empty($classId)) {
return new JsonResponse([]);
}
Expand All @@ -470,7 +470,7 @@ public function loadDataObjectAttributesAction(Request $request, TransformationD
*/
public function loadDataObjectClassificationStoreAttributesAction(Request $request, TransformationDataTypeService $transformationDataTypeService)
{
$classId = $request->query->getString('class_id');
$classId = $request->query->get('class_id');
if (empty($classId)) {
return new JsonResponse([]);
}
Expand All @@ -492,18 +492,18 @@ public function loadDataObjectClassificationStoreAttributesAction(Request $reque
*/
public function loadDataObjectClassificationStoreKeysAction(Request $request, ClassificationStoreDataTypeService $classificationStoreDataTypeService)
{
$sortParams = QueryParams::extractSortingSettings(['sort' => $request->query->getString('sort')]);
$sortParams = QueryParams::extractSortingSettings(['sort' => $request->query->get('sort')]);

$list = $classificationStoreDataTypeService->listClassificationStoreKeyList(
strip_tags($request->query->getString('class_id')),
strip_tags($request->query->getString('field_name')),
strip_tags($request->query->getString('transformation_result_type')),
strip_tags($request->query->get('class_id')),
strip_tags($request->query->get('field_name')),
strip_tags($request->query->get('transformation_result_type')),
$sortParams['orderKey'] ?? 'name',
$sortParams['order'] ?? 'ASC',
$request->query->getInt('start'),
$request->query->getInt('limit'),
strip_tags($request->query->getString('searchfilter')),
strip_tags($request->query->getString('filter'))
strip_tags($request->query->get('searchfilter')),
strip_tags($request->query->get('filter'))
);

$data = [];
Expand Down Expand Up @@ -543,7 +543,7 @@ public function loadDataObjectClassificationStoreKeysAction(Request $request, Cl
*/
public function loadDataObjectClassificationStoreKeyNameAction(Request $request)
{
$keyId = $request->query->getString('key_id');
$keyId = $request->query->get('key_id');
$keyParts = explode('-', $keyId);
if (count($keyParts) === 2) {
$keyGroupRelation = DataObject\Classificationstore\KeyGroupRelation::getByGroupAndKeyId((int)$keyParts[0], (int)$keyParts[1]);
Expand Down Expand Up @@ -574,7 +574,7 @@ public function loadDataObjectClassificationStoreKeyNameAction(Request $request)
*/
public function startBatchImportAction(Request $request, ImportPreparationService $importPreparationService)
{
$configName = $request->request->getString('config_name');
$configName = $request->request->get('config_name');
$success = $importPreparationService->prepareImport($configName, true);

return new JsonResponse([
Expand All @@ -592,7 +592,7 @@ public function startBatchImportAction(Request $request, ImportPreparationServic
*/
public function checkImportProgressAction(Request $request, ImportProcessingService $importProcessingService)
{
$configName = $request->query->getString('config_name');
$configName = $request->query->get('config_name');

return new JsonResponse($importProcessingService->getImportStatus($configName));
}
Expand All @@ -608,7 +608,7 @@ public function isCronExpressionValidAction(Request $request)
{
$message = '';
$success = true;
$cronExpression = $request->query->getString('cron_expression');
$cronExpression = $request->query->get('cron_expression');
if (!empty($cronExpression)) {
try {
new CronExpression($cronExpression);
Expand All @@ -634,7 +634,7 @@ public function isCronExpressionValidAction(Request $request)
*/
public function cancelExecutionAction(Request $request, ImportProcessingService $importProcessingService)
{
$configName = $request->request->getString('config_name');
$configName = $request->request->get('config_name');
$importProcessingService->cancelImportAndCleanupQueue($configName);

return new JsonResponse([
Expand Down Expand Up @@ -662,7 +662,7 @@ public function uploadImportFileAction(Request $request, FilesystemOperator $pim
throw new Exception('The filename of the upload data is empty');
}

/*$target = $this->getImportFilePath($request->query->getString('config_name'));
/*$target = $this->getImportFilePath($request->query->get('config_name'));
$pimcoreDataImporterUploadStorage->write($target, file_get_contents($sourcePath));
@unlink($sourcePath);*/
Expand Down Expand Up @@ -709,7 +709,7 @@ protected function getImportFilePath(string $configName): string
public function hasImportFileUploadedAction(Request $request, Translator $translator, FilesystemOperator $pimcoreDataImporterUploadStorage)
{
try {
$importFile = $this->getImportFilePath($request->query->getString('config_name'));
$importFile = $this->getImportFilePath($request->query->get('config_name'));

if ($pimcoreDataImporterUploadStorage->fileExists($importFile)) {
return new JsonResponse(['success' => true, 'filePath' => $importFile, 'message' => $translator->trans('plugin_pimcore_datahub_data_importer_configpanel_type_upload_exists', [], 'admin')]);
Expand Down

0 comments on commit bc13922

Please sign in to comment.