Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix no_cache test #842

Merged
merged 6 commits into from Mar 11, 2024
Merged

[Bug]: Fix no_cache test #842

merged 6 commits into from Mar 11, 2024

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Mar 1, 2024

Resolves https://github.com/pimcore/data-hub/actions/runs/8105954504/job/22155122634 (11.x)

removed inDebugMode(true) line because it used to be a setter that got removed in 10 in favor of PIMCORE_DEV_MODE
could be changed to if (\Pimcore::inDebugMode()){ to bypass this test, but the env seem not being considered after the dotEnv bootstrap symfony runtime changes in the core pimcore/pimcore#16652

@fashxp fashxp added this to the 1.7.0 milestone Mar 11, 2024
@kingjia90 kingjia90 marked this pull request as ready for review March 11, 2024 11:36
@kingjia90 kingjia90 modified the milestones: 1.7.0, 1.6.6 Mar 11, 2024
@kingjia90 kingjia90 changed the base branch from 1.6 to 1.x March 11, 2024 11:38
@kingjia90 kingjia90 changed the base branch from 1.x to 1.6 March 11, 2024 11:38
@kingjia90 kingjia90 linked an issue Mar 11, 2024 that may be closed by this pull request
@brusch brusch merged commit 9fa553f into 1.6 Mar 11, 2024
9 checks passed
@brusch brusch deleted the fix-cache-debug-test branch March 11, 2024 13:11
@kingjia90 kingjia90 modified the milestones: 1.7.0, 1.6.6 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Codeception tests fail
3 participants