Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QueryType for Version on Assets #838

Merged
merged 5 commits into from May 3, 2024
Merged

Add QueryType for Version on Assets #838

merged 5 commits into from May 3, 2024

Conversation

leitge
Copy link
Contributor

@leitge leitge commented Feb 25, 2024

No description provided.

Corepex
Corepex requested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leitge, thanks for your PR.
Tested it - looks good to me :) just one (very picky) thing to make the IDE happy 🤣

src/GraphQL/Resolver/AssetType.php Show resolved Hide resolved
@Corepex Corepex self-assigned this Apr 5, 2024
@Corepex
Copy link
Contributor

Corepex commented May 3, 2024

@leitge friendly reminder ⏰ 🍭

leitge and others added 2 commits May 3, 2024 10:23
@leitge @Corepex
Apply suggestions from code review
1c58c29 
Co-authored-by: Christian F. <kontakt+github@christian-feldkirchner.at>
@leitge @github-actions
Apply php-cs-fixer changes
d32a8c3
leitge
leitge commented May 3, 2024
View reviewed changes
Copy link
Contributor Author

@leitge leitge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@leitge
Copy link
Contributor Author

leitge commented May 3, 2024

@Corepex done ;)

Corepex
Corepex approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@Corepex Corepex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @leitge for your PR.
Great to actively work with you on data-hub 💯

@Corepex Corepex merged commit 3bb4b4f into pimcore:1.x May 3, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
@Corepex Corepex added this to the 1.8.0 milestone May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Corepex Corepex Corepex approved these changes

Assignees

@Corepex Corepex

Labels
Pimcore:ToDo
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leitge @Corepex @wisconaut