[Improvement]: Add configuration storage locations to Symfony tree #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce-to-bundle' into 710-improvement-add-configuration-storage-locations-to-symfony-tree
…n-storage-locations-to-symfony-tree' into 710-improvement-add-configuration-storage-locations-to-symfony-tree
This reverts commit 492b21e.
mcop1
reviewed
Mar 30, 2023
There was a problem hiding this comment.
We should add documentation for that too, maybe somewhere here (separate sections for Pimcore 10.6 and 11)
Line 31 in 54673a5
Co-authored-by: mcop1 <89011527+mcop1@users.noreply.github.com>
|
One more thing. What about tests? We are using the env variable here, but that will not work with 11 anymore, right? data-hub/.github/ci/files/.env.test Line 1 in 9139c14 |
|
Regarding tests, please see the follow up #721 |
mcop1
deleted the
710-improvement-add-configuration-storage-locations-to-symfony-tree
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #710