Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Correct POEditor workflow and fix compatability to Pimcore 11 #715

Merged
merged 3 commits into from Apr 3, 2023
Merged

[Task] Correct POEditor workflow and fix compatability to Pimcore 11 #715

merged 3 commits into from Apr 3, 2023

Conversation

Corepex
Copy link
Contributor

@Corepex Corepex commented Mar 28, 2023

follow-up for: #713

@Corepex Corepex added the Task label Mar 28, 2023
@Corepex Corepex added this to the 1.6.0 milestone Mar 28, 2023
@Corepex
Copy link
Contributor Author

Corepex commented Mar 28, 2023 •
edited

Tests should work when pimcore/pimcore#14618 (https://github.com/pimcore/pimcore/pull/14618/files#diff-c812583a60c34c23ab000a9fdbf0b38d5b1b66d7c10e4e48635c5a90a0cafc2aR60) is merged

@mcop1 mcop1 changed the title [Task] Correct POEditor workflow [Task] Correct POEditor workflow and fix compatability to Pimcore 11 Mar 28, 2023
@mcop1
Copy link
Contributor

mcop1 commented Apr 3, 2023

Regarding tests, please see follow up ticket #721

@mcop1 mcop1 merged commit 9e56968 into 1.x Apr 3, 2023
7 of 9 checks passed
@mcop1 mcop1 deleted the correct-poeditor-file-extension branch April 3, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mcop1 mcop1

Labels
Task
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Corepex @mcop1