New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter query type based on FilterDefinition objects - Work in Progess #149
Open
das-peter
wants to merge
69
commits into
pimcore:1.x
Choose a base branch
from
das-peter:filter-query-type
base: 1.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration into dedicated method which is called conditionally.
…se the filter is running using the DB backend. We still need a workaround for elastic and / or search back-ends.
see also pimcore/pimcore#3537 |
…st be represented by a single instance
Any update here? |
…-customizations # Conflicts: # src/GraphQL/Query/QueryType.php
@fashxp ping |
…ery-type # Conflicts: # src/GraphQL/Query/QueryType.php
added support for object arrays instead of string arrays only changed structure for request filters directly without "facet" hierarchy to get different filter types separately added filterType for each supported filter
…terTypes" needed to create dynamically Filter Object based on configurated filter types in ecommerce-config.yml changed QueryType.php to create dynamically Filter Object Types based on configuration
…er description in the generated documentation skip filter fields in Resolver\QueryType.php which are not in the GraphQL Request to prevent empty arrays in the response
… fragment name which could be anything
… fragment name which could be anything
…erent FilterTypes
…slated while stored in elastic and the relation object are translated separate with an event
…' into filter-query-type # Conflicts: # src/GraphQL/Query/QueryType.php # src/GraphQL/Resolver/AssetType.php # src/GraphQL/Resolver/QueryType.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to be able to use the GraphQL integration with the
IndexService
from theEcommerceFrameworkBundle
.Currently this pull requests works with following GraphQL Syntax:
The query returns the matching nodes as well as the factes defined in the filterDefinition 133836.
Return format of the facets:
Tasks I'm currently aware of:
HijackAbstractFilterType::isMultiValueFilter()
. Would need refactoring inEcommerceFrameworkBundle
{field: "parentCategoryIds", values: ["72448"]}
instead{field: "parentCategoryIds", values: "72448"}
Attempts to use the
UnionType
to allow multiple types as input failed so far.EcommerceFrameworkBundle
to allow accessing the field name fromAbstractFilterType
. Currently we use scope hijacking inHijackAbstractFilterType::getFieldFromFilter()
to call the necessary but protected methods.