Fix: PHPStan

pimcore · Mar 30, 2023 · 5f25d14 · 5f25d14
1 parent 5fcd81f
commit 5f25d14
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -5,6 +5,21 @@ parameters:
 			count: 3
 			path: src/DependencyInjection/Configuration.php
 
+        -
+            message: "#Call to static method addConfigLocationWithWriteTargetNodes() on an unknown class#"
+		    count: 1
+            path: src/DependencyInjection/Configuration.php
+
+        -
+            message: "#Call to static method getConfigNodeFromSymfonyTree() on an unknown class#"
+		    count: 1
+            path: src/DependencyInjection/PimcoreDataHubExtension.php
+
+        -
+            message: "#Call to static method getSymfonyConfigFiles() on an unknown class#"
+		    count: 1
+            path: src/DependencyInjection/PimcoreDataHubExtension.php
+
 		-
 			message: "#^Constructor of class Pimcore\\\\Bundle\\\\DataHubBundle\\\\GraphQL\\\\AssetType\\\\AssetFolderType has an unused parameter \\$config\\.$#"
 			count: 1

diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php
@@ -47,7 +47,9 @@ public function getConfigTreeBuilder()
         $this->addConfigurationsNode($rootNode);
         $this->addSupportedTypes($rootNode);
 
-        ConfigurationHelper::addConfigLocationWithWriteTargetNodes($rootNode, ['data_hub']);
+        if(\Pimcore\Version::getMajorVersion() >= 11) {
+            ConfigurationHelper::addConfigLocationWithWriteTargetNodes($rootNode, ['data_hub']);
+        }
 
         return $treeBuilder;
     }

diff --git a/src/GraphQL/Query/Operator/Thumbnail.php b/src/GraphQL/Query/Operator/Thumbnail.php
@@ -64,7 +64,7 @@ public function getLabeledValue($element, ResolveInfo $resolveInfo = null)
             if ($childResult->value instanceof Asset\Image || $childResult->value instanceof Asset\Video) {
                 $childValue = $result->value = $childResult->value;
                 $thumbnail = $childValue->getThumbnail($this->thumbnailConfig, false);
-                $result->value = $thumbnail->getPath(false);
+                $result->value = $thumbnail->getPath();
             }
         }