Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to PHP CS Fixer v3 #532

Merged
merged 9 commits into from Apr 29, 2024
Merged

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Apr 22, 2024

See other pimcore repositories

@blankse blankse mentioned this pull request Apr 23, 2024
@blankse
Copy link
Contributor Author

blankse commented Apr 23, 2024

PhpStan is fixed by #533

@blankse
Copy link
Contributor Author

blankse commented Apr 26, 2024

Merged the 4.0 branch to fix the php stan errors here

@markus-moser
Copy link
Contributor

@blankse
Thanks a lot! I would prefer if we execute the github workflows also for PRs like here: https://github.com/pimcore/opensearch-client/blob/1.x/.github/workflows/php-cs-fixer.yaml#L4

With this the CS fixer changes would be handled in the PR and for example in this one we could directly see the changes. When merging a PR we could then squash it and would have a clean commit history. WDYT?

@blankse
Copy link
Contributor Author

blankse commented Apr 27, 2024

@markus-moser I would also prefer this. Did you test it with pull requests from forks? It seems not to work. The github-actions bot doesn't have permission to write in my repository. I checked the "Allow edits and access to secrets by maintainers" checkbox:
Permission to blankse/customer-data-framework.git denied to github-actions[bot].

See: https://github.com/pimcore/customer-data-framework/actions/runs/8862166212/job/24334805955?pr=532

@blankse
Copy link
Contributor Author

blankse commented Apr 27, 2024

@markus-moser
Copy link
Contributor

@blankse Oh, sorry, no I never tested it with forks. Thank you very much for figuring this tricky thing out, let's give it a try 👍

@markus-moser markus-moser merged commit d241667 into pimcore:4.0 Apr 29, 2024
6 checks passed
@markus-moser markus-moser mentioned this pull request Apr 29, 2024
@markus-moser
Copy link
Contributor

@blankse Thanks again - seems to work fine 👍 (see #536)

I'll discuss it with the team if we should make this our default behaviour for our bundles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants