LinkActivityDefinition preview doesn't work: Create PreviewGenerator (#…

…494) * LinkActivityDefinition preview doesn't work: Create PreviewGenerator * Move to PreviewGenerator namespace * Fix deprecation
pimcore · Aug 21, 2023 · de98f9e · de98f9e
1 parent e1caae8
commit de98f9e
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 2 deletions.
diff --git a/install/class_source/class_LinkActivityDefinition_export.json b/install/class_source/class_LinkActivityDefinition_export.json
@@ -513,6 +513,7 @@
     "group": "CustomerManagement",
     "showAppLoggerTab": false,
     "linkGeneratorReference": "@CustomerManagementFrameworkBundle\\LinkGenerator\\LinkActivityDefinitionLinkGenerator",
+    "previewGeneratorReference": "@CustomerManagementFrameworkBundle\\PreviewGenerator\\LinkActivityDefinitionPreviewGenerator",
     "compositeIndices": [],
     "showFieldLookup": false,
     "propertyVisibility": {

diff --git a/src/Controller/Preview/ObjectPreviewController.php b/src/Controller/Preview/ObjectPreviewController.php
@@ -27,11 +27,11 @@
 class ObjectPreviewController extends FrontendController
 {
     /**
-     * @Route("/link-activity-definition-preview")
+     * @Route("/link-activity-definition-preview", name="cmf_link_activity_definition_preview")
      */
     public function linkActivityDefinitionPreviewAction(Request $request): Response
     {
-        $activityDefinition = LinkActivityDefinition::getById($request->get('pimcore_object_preview'));
+        $activityDefinition = LinkActivityDefinition::getById($request->query->getInt('pimcore_object_preview'));
 
         return $this->render(
             '@PimcoreCustomerManagementFramework/preview/object_preview/link_activity_definition_preview.html.twig',

diff --git a/src/PreviewGenerator/LinkActivityDefinitionPreviewGenerator.php b/src/PreviewGenerator/LinkActivityDefinitionPreviewGenerator.php
@@ -0,0 +1,40 @@
+<?php
+
+/**
+ * Pimcore
+ *
+ * This source file is available under two different licenses:
+ * - GNU General Public License version 3 (GPLv3)
+ * - Pimcore Commercial License (PCL)
+ * Full copyright and license information is available in
+ * LICENSE.md which is distributed with this source code.
+ *
+ *  @copyright  Copyright (c) Pimcore GmbH (http://www.pimcore.org)
+ *  @license    http://www.pimcore.org/license     GPLv3 and PCL
+ */
+
+namespace CustomerManagementFrameworkBundle\PreviewGenerator;
+
+use Pimcore\Model\DataObject\ClassDefinition\PreviewGeneratorInterface;
+use Pimcore\Model\DataObject\Concrete;
+use Symfony\Component\Routing\RouterInterface;
+
+class LinkActivityDefinitionPreviewGenerator implements PreviewGeneratorInterface
+{
+    public function __construct(protected RouterInterface $router)
+    {
+    }
+
+    public function generatePreviewUrl(Concrete $object, array $params): string
+    {
+        return $this->router->generate(
+            'cmf_link_activity_definition_preview',
+            ['pimcore_object_preview' => $object->getId()]
+        );
+    }
+
+    public function getPreviewConfig(Concrete $object): array
+    {
+        return [];
+    }
+}
diff --git a/src/Resources/config/services.yml b/src/Resources/config/services.yml
@@ -163,6 +163,8 @@ services:
         arguments:
             - '%pimcore_customer_management_framework.url_activity_tracker.linkCmfcPlaceholder%'
 
+    CustomerManagementFrameworkBundle\PreviewGenerator\LinkActivityDefinitionPreviewGenerator: ~
+
     cmf.link-activity-definition.linkgenerator:
         alias: CustomerManagementFrameworkBundle\LinkGenerator\LinkActivityDefinitionLinkGenerator
         deprecated: