Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: Dynamic Text Labels preview #518

Merged
merged 1 commit into from May 17, 2024

Conversation

Navino16
Copy link
Contributor

When going to the preview of a Dynamic Text Labels we get the following error:
image

After fixing this issue, when we use a Custom Renderer Class we get this error:
image

This PR fix this 2 errors.

Also, the first fix is a duplicate of #379 which seems to be inactive

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@robertSt7 robertSt7 self-assigned this May 17, 2024
@robertSt7 robertSt7 added this to the 1.4.3 milestone May 17, 2024
@robertSt7 robertSt7 merged commit 32b31e5 into pimcore:1.4 May 17, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
@robertSt7
Copy link
Contributor

@Navino16 Thanks for the fix

@robertSt7 robertSt7 added the Bug label May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants