Fix UX for inherited boolean properties

[frc0necto]

This PR addresses a UX issue with asset/document properties of boolean type.

Problem description

Affected version

• all versions since 2015?
• found it in 11.1.2
• still there in 11.2.2

Steps to reproduce

• create a property in the root leaf of the asset tree, type boolean, inheritable, checked
• have an asset ("Asset A") somewhere in the tree

Expected behavior

• "Asset A" displays a checked checkbox
• the checkbox cannot be changed

Actual behavior

• "Asset A" displays a string "true" (or an empty cell if the root property is not checked)
• the value toggles between "true" and "" when clicked

Discussion

Impact on UX

It is confusing to the user because one can change the value, the value appears to have changed, however, saving the changed value does not do anything - in fact, it can only be seen once the tab is reloaded and one navigates to the properties again to see that the value resets to the previous value.

We found that this very behavior only appears for properties of boolean type - which indicates that the behavior is not intended as is.

How it came to be this way

Checkbox not displayed

We did some digging in the code history and found that in July 2018, the change which prevented displaying a checkbox was introduced during a massive directory structure refactoring 2fb5fa7. It seems that code has been consolidated from various sources back then (pimcore/static/js/pimcore/settings/metadata/predefined.js, pimcore/static5/js/pimcore/settings/website.js, pimcore/static6/js/pimcore/asset/metadata.js, ...). these sources have been created in 2014 and 2015. Unfortunately, we could not find any hint on why the change was necessary.

Toggle change for inherited boolean properties

Changing a boolean property, even if inherited, has been moved in 2015 and thus has been created even before. 41b0c81

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[frc0necto]

I have read the CLA Document and I hereby sign the CLA

[blankse]

@frc0necto Target branch of bug fixes should be 1.4

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[robertSt7]

@frc0necto Thanks for the fix