Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consideration of checked tags with collapsed parent tag #445

Open
wants to merge 1 commit into
base: 1.4
Choose a base branch
from

Conversation

saschabaecher-twocream
Copy link
Contributor

Situation:

  • Create two tags, each of which has a parent tag
  • Assign a tag to an object
  • Assign another tag and the previously added tag to another object of the same type
  • Go to the object search
  • Open the tag filtering
  • First check the tag that only one of the objects has and then collapse the parent tag
  • Now tick the second tag that both objects have
  • The first object that only has one of the tags is also displayed

Expected Behavior:

It should be noted that the checked tags are also taken into considered in the filtering, even if the parent tag is collapsed.

Fix:

One solution is to iterate over all tags to check if any of them are selected and include them in the list. This way, the checked tags are also considered in the filtering, even if the parent tag is collapsed.

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kingjia90 kingjia90 changed the base branch from 1.3 to 1.4 March 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants