feat: add unitless support

pierreburel · Aug 21, 2023 · c9390f5 · c9390f5
1 parent ba2456d
commit c9390f5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/_rem.scss b/_rem.scss
@@ -23,8 +23,8 @@ $px-only: false !default;
   @each $value in $values {
     @if meta.type-of($value) == "number" and math.unit($value) == "rem" and $to == "px" {
       $result: list.append($result, _divide($value, 1rem) * $baseline, $separator);
-    } @else if meta.type-of($value) == "number" and math.unit($value) == "px" and $to == "rem" {
-      $result: list.append($result, _divide($value, $baseline) * 1rem, $separator);
+    } @else if meta.type-of($value) == "number" and (math.unit($value) == "px" or math.unit($value) == '') and $value != 0 and $to == "rem" {
+      $result: list.append($result, _divide(if(math.unit($value) == 'px', $value, $value * 1px), $baseline) * 1rem, $separator);
     } @else if meta.type-of($value) == "list" {
       $result: list.append($result, _convert($to, $value...), $separator);
     } @else {

diff --git a/index.test.js b/index.test.js
@@ -15,14 +15,19 @@ async function run(input, output, config = `@use "." as rem;`) {
   expect(a).toEqual(b);
 };
 
+it('Unitless', () => run(
+  '.simple { font-size: rem.convert(24); }',
+  '.simple { font-size: 1.5rem; }'
+));
+
 it('Simple', () => run(
   '.simple { font-size: rem.convert(24px); }',
   '.simple { font-size: 1.5rem; }'
 ));
 
 it('Multiple values', () => run(
-  '.multiple { padding: rem.convert(5px 10px); }',
-  '.multiple { padding: 0.3125rem 0.625rem; }'
+  '.multiple { padding: rem.convert(5px 10px 0 24); }',
+  '.multiple { padding: 0.3125rem 0.625rem 0 1.5rem; }'
 ));
 
 it('Multiple mixed values', () => run(